Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial commit to add support for various Candeo devices #3905

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

candeodevelopment
Copy link

@candeodevelopment candeodevelopment commented Feb 26, 2025

Proposed change

Adds specific Quirks for:

Candeo C205 Switch Module
Candeo C-ZB-SM205-2G Switch Module
Candeo C203 Dimmer Module
Candeo C204 Dimmer Module
Candeo C-ZB-DM204 Dimmer Module

Additional information

We've been providing Quirks to our customers for some time via our own Github repository, we're hoping now to have them officially directly integrated in order to alleviate customers needing to manually add them to their ZHA configuration.

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

This is our first submission to the project, so hopefully we're doing things correctly.

Please let us know if not!

candeodevelopment and others added 2 commits February 26, 2025 10:44
Adds specific quirks for:

Candeo C205 Switch Module
Candeo C-ZB-SM205-2G Switch Module
Candeo C203 Dimmer Module
Candeo C204 Dimmer Module
Candeo C-ZB-DM204 Dimmer Module
Copy link

codecov bot commented Feb 26, 2025

Codecov Report

Attention: Patch coverage is 93.75000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 91.03%. Comparing base (b87ac89) to head (76d3455).
Report is 15 commits behind head on dev.

Files with missing lines Patch % Lines
...uirks/candeo/candeo_c-zb-dm204_dimmer_module_V2.py 93.75% 1 Missing ⚠️
...ks/candeo/candeo_c-zb-sm205-2g_switch_module_V2.py 93.75% 1 Missing ⚠️
zhaquirks/candeo/candeo_c203_dimmer_module_V2.py 93.75% 1 Missing ⚠️
zhaquirks/candeo/candeo_c204_dimmer_module_V2.py 93.75% 1 Missing ⚠️
zhaquirks/candeo/candeo_c205_switch_module_V2.py 93.75% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3905      +/-   ##
==========================================
+ Coverage   91.00%   91.03%   +0.02%     
==========================================
  Files         328      333       +5     
  Lines       10656    10736      +80     
==========================================
+ Hits         9698     9773      +75     
- Misses        958      963       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@TheJulianJES TheJulianJES added v2 quirk Quirks using v2 API. Might add custom entities that need translation keys in HA. needs reviewer answer An answer from a reviewer is needed (e.g. why a PR isn't acceptable in the current state). labels Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs reviewer answer An answer from a reviewer is needed (e.g. why a PR isn't acceptable in the current state). v2 quirk Quirks using v2 API. Might add custom entities that need translation keys in HA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants