Skip to content

Add Third Reality temperature/humidity sensor lite quirk #3925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
+75 −0
Open

Add Third Reality temperature/humidity sensor lite quirk #3925

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1b7ac7e
Modify the private cluster of the temperature and humidity sensor.
hwzolin Mar 4, 2025
f23960d
Apply pre-commit auto fixes
pre-commit-ci[bot] Mar 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Loading
Loading status checks…
Apply pre-commit auto fixes
@pre-commit-ci
pre-commit-ci[bot] committed Mar 4, 2025
commit f23960dfffe1c75f6b0a22bc295188d66ed3c38d
2 changes: 1 addition & 1 deletion zhaquirks/thirdreality/temperature_and_humidity_sensor_lite.py
View file
Original file line number Diff line number Diff line change
@@ -38,7 +38,7 @@ class AttributeDefs(BaseAttributeDefs):

(
QuirkBuilder("Third Reality, Inc", "3RTHS0224Z")
.also_applies_to("Third Reality","3RTHS0224Z")
.also_applies_to("Third Reality", "3RTHS0224Z")
.replaces(ThirdRealityTemperatureAndHumidityCluster)
.removes(PollControl.cluster_id)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this cluster removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@puddly Hello, since our temperature and humidity sensor lite OTA on ZHA, it often takes a long time to update OTA from version 30 onwards. Generally, after 20 minutes, the OTA will fail. In the Lite 30 version, after the OTA fails, the OTA will not continue to start the OTA from the progress of the last failure.

We thought it might be the PollControl cluster, so we deleted it, but it didn't work. Later, when there was no abnormality in use, I forgot to remove this deletion statement.

.number(

Unchanged files with check annotations Beta

View file
zhaquirks/tuya/mcu/__init__.py
self.debug("handle_set_time_request payload: %s", payload)
payload_rsp = TuyaTimePayload()
utc_now = datetime.datetime.utcnow() # noqa: DTZ003

Check warning on line 314 in zhaquirks/tuya/mcu/__init__.py

GitHub Actions / shared-ci / Run tests Python 3.12 

datetime.datetime.utcnow() is deprecated and scheduled for removal in a future version. Use timezone-aware objects to represent datetimes in UTC: datetime.datetime.now(datetime.UTC).

Check warning on line 314 in zhaquirks/tuya/mcu/__init__.py

GitHub Actions / shared-ci / Run tests Python 3.13 

datetime.datetime.utcnow() is deprecated and scheduled for removal in a future version. Use timezone-aware objects to represent datetimes in UTC: datetime.datetime.now(datetime.UTC).

Check warning on line 314 in zhaquirks/tuya/mcu/__init__.py

GitHub Actions / shared-ci / Run tests Python 3.13 

datetime.datetime.utcnow() is deprecated and scheduled for removal in a future version. Use timezone-aware objects to represent datetimes in UTC: datetime.datetime.now(datetime.UTC).
now = datetime.datetime.now()
offset_time = datetime.datetime(self.set_time_offset, 1, 1)