Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ubisys S1, S2 WIP #3959

Draft
wants to merge 2 commits into
base: dev
Choose a base branch
from
Draft

ubisys S1, S2 WIP #3959

wants to merge 2 commits into from

Conversation

FlorianBruckner
Copy link

Proposed change

Manufacturer specific cluster for ubisys devices for device configuration as requested in #3942

Additional information

see https://www.ubisys.de/wp-content/uploads/ubisys-s1-technical-reference.pdf and https://www.ubisys.de/downloads/ubisys-input-configuration-integrators-guide.pdf

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

Copy link

codecov bot commented Mar 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.00%. Comparing base (b87ac89) to head (e8bcd45).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #3959   +/-   ##
=======================================
  Coverage   91.00%   91.00%           
=======================================
  Files         328      328           
  Lines       10656    10656           
=======================================
  Hits         9698     9698           
  Misses        958      958           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@FlorianBruckner
Copy link
Author

Dear @TheJulianJES, Dear @puddly

I have started with a device handler for my ubisys devices to allow for device configuration. Unfortunately I am stuck and hope to get some help from you.

The documentation (https://www.ubisys.de/wp-content/uploads/ubisys-s1-technical-reference.pdf) defines the attributes as

This attribute is an array (ZCL data type 0x48) of 8-bit data (ZCL data type 0x08).

and

This attribute is an array (ZCL data type 0x48) of raw binary data (ZCL data type 0x41).

How would I declare these attributes and what would be the format (in the UI) for input and output? Or is this approach unfit for this purpose anyway and you would suggest a different one?

@puddly
Copy link
Contributor

puddly commented Mar 13, 2025

The cluster commands and attributes need to be defined either way, regardless of how entities interface with them.

The ZCL array type define the data type dynamically so you can just specify the type as Array (there are other instances of this in the codebase).

Each array element seems to encompass two bits of configuration: disabling the input and inverting its logic level. I guess you can skip the input disabling part and just provide dropdowns to select the logic level? On the other hand, this can also easily be done in an automation.

I don't believe we have an API yet to process the value of an attribute bidirectionally, when creating a v2 quirk entity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants