Add Sonoff SNZB-03P motion sensor

[panther7]

Proposed change

• add Sonoff SNZB-03P motion sensor ([Device Support Request] SONOFF SNZB-03P #3188)
• author of script: @BillyBlaze (modified by @panther7)

Checklist

• The changes are tested and work correctly
• pre-commit checks pass / the code has been formatted using Black
• Tests have been added to verify that the new code works

[codecov]

Codecov Report

Attention: Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.05%. Comparing base (2fd3586) to head (0ce8446).
Report is 13 commits behind head on dev.

Files with missing lines	Patch %	Lines
zhaquirks/sonoff/snzb03p.py	94.44%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##              dev    #3979   +/-   ##
=======================================
  Coverage   91.04%   91.05%           
=======================================
  Files         331      332    +1     
  Lines       10698    10716   +18     
=======================================
+ Hits         9740     9757   +17     
- Misses        958      959    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[TheJulianJES]

So the IasZone cluster doesn't do anything at all?
Can we use .prevent_default_entity_creation(endpoint_id=1, cluster_id=IasZone.cluster_id) here instead?
It's a new functionality that doesn't entirely remove the cluster for us, just disables the auto discovery for ZHA entities on that cluster.

[panther7]

Yes, cluster is always "unavailable".

[TheJulianJES]

I think we can use manufacturer_id_override: t.uint16_t = foundation.ZCLHeader.NO_MANUFACTURER_ID instead. See this PR as an example: https://github.com/zigpy/zha-device-handlers/pull/3910/files#diff-6c9212ca1af0b4604a20edb89247ceb6d30b010041e81fde812465a2f73a3ccbR24

[panther7]

Can not be used.

Replace with manufacturer_id_override: t.uint16_t = foundation.ZCLHeader.NO_MANUFACTURER_ID is broken:

• eWeLink SNZB-03P is always detected
• Last illumination state is Unavailable

With _is_manuf_specific(self): return False is right:

[TheJulianJES]

Ah, interesting. This is a default attribute. It's also used by the Hue motion sensors, though it's reported as an "unsupported attribute" if we read it during pairing, for some reason, so I've not added that as a config entity for now. We could add the entities via quirks v2 for both sensors, but we might be able to add this as a general entity in ZHA. I'll have to come back to this.

[panther7]

If removed, then same issue like #3979 (comment)

[TheJulianJES]

Z2M seems to specify a manufacturer code: https://github.com/Koenkk/zigbee-herdsman-converters/blob/216ba1a56f1b21fda7de7204839f0fb838df0b85/src/devices/sonoff.ts#L1162
Do we even need this at all? By default, zigpy will use the manufacturer code for the device if the attribute is marked as is_manufacturer_specific (it is) and if the cluster is in the manufacturer specific range (it is).

I guess this is only really needed if we explicitly poll/read the attribute ourselves though (through the "Manage Zigbee device -> Clusters" debug menu).

[panther7]

Thanks for huge feedback.

This PR is only request with originial code from @BillyBlaze and with (little) mods.

I have zero experience with Python and device handlers, bit i will try it.

[panther7]

@TheJulianJES What next now? If i use some from your suggest, some functions wrong.