Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support string as an argument to the tag function #132

Merged
merged 4 commits into from
Dec 20, 2017

Conversation

fatfisz
Copy link
Collaborator

@fatfisz fatfisz commented Dec 18, 2017

This is the feature requested in #118.

TODO

  • More tests?
  • Docs

@codecov-io
Copy link

codecov-io commented Dec 18, 2017

Codecov Report

Merging #132 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #132   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          23     23           
  Lines         151    153    +2     
=====================================
+ Hits          151    153    +2
Impacted Files Coverage Δ
src/TemplateTag/TemplateTag.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1d8901...42e5a84. Read the comment docs.

@fatfisz fatfisz merged commit 25937c8 into master Dec 20, 2017
@fatfisz fatfisz deleted the support-string-argument branch December 20, 2017 21:22
This was referenced Dec 21, 2017
pizzafroide pushed a commit to pizzafroide/common-tags that referenced this pull request Jan 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants