Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI Pipeline and release drafter #1

Merged
merged 11 commits into from
Aug 20, 2021
Merged

Add CI Pipeline and release drafter #1

merged 11 commits into from
Aug 20, 2021

Conversation

Anselmoo
Copy link
Owner

@Anselmoo Anselmoo commented Aug 7, 2021

Starting to implement a CI/CD pipeline for spectrafit in GitHub

@Anselmoo Anselmoo self-assigned this Aug 7, 2021
@Anselmoo Anselmoo added enhancement New feature or request good first issue Good for newcomers labels Aug 7, 2021
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Aug 20, 2021

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.55%.

Quality metrics Before After Change
Complexity 57.70 ⛔ 57.76 ⛔ 0.06 👎
Method Length 112.88 🙂 114.03 🙂 1.15 👎
Working memory 11.04 😞 11.05 😞 0.01 👎
Quality 38.57% 😞 38.02% 😞 -0.55% 👎
Other metrics Before After Change
Lines 1083 1384 301
Changed files Quality Before Quality After Quality Change
spectrafit/init.py 100.00% ⭐ 100.00% ⭐ 0.00%
spectrafit/models.py 23.23% ⛔ 22.34% ⛔ -0.89% 👎
spectrafit/plotting.py 65.40% 🙂 65.60% 🙂 0.20% 👍
spectrafit/report.py 18.06% ⛔ 16.97% ⛔ -1.09% 👎
spectrafit/spectrafit.py 66.20% 🙂 64.91% 🙂 -1.29% 👎
spectrafit/test/init.py % % %

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
spectrafit/models.py calculated_models 122 ⛔ 705 ⛔ 15 😞 8.63% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
spectrafit/models.py solver_model 122 ⛔ 523 ⛔ 13 😞 11.64% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
spectrafit/report.py fit_report_as_dict 59 ⛔ 509 ⛔ 14 😞 12.12% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
spectrafit/spectrafit.py command_line_runner 17 🙂 156 😞 14 😞 40.02% 😞 Try splitting into smaller methods. Extract out complex expressions
spectrafit/spectrafit.py extracted_from_command_line_runner 18 🙂 212 ⛔ 6 ⭐ 50.19% 🙂 Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant