-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: ✅ Add unit tests for SpectraFit version and Python 3.8 deprecation warning #1641
Conversation
Review changes with SemanticDiff. Analyzed 3 of 3 files. Overall, the semantic diff is 5% smaller than the GitHub diff.
|
Reviewer's Guide by SourceryThis pull request adds unit tests for SpectraFit version and Python 3.8 deprecation warning, while also making minor improvements to code documentation and readability. The changes focus on enhancing the codebase's maintainability and preparing for future Python version support. Class diagram for DataFramePlot class changesclassDiagram
class DataFramePlot {
+plot_2dataframes(args_plot: PlotAPI, df_1: pd.DataFrame, df_2: Optional[pd.DataFrame])
+_plot_single_dataframe(args_plot: PlotAPI, df: pd.DataFrame) : Figure
+_plot_two_dataframes(args_plot: PlotAPI, df_1: pd.DataFrame, df_2: pd.DataFrame) : Figure
+plot_dataframe(args_plot: PlotAPI, df: pd.DataFrame)
+plot_global_fit(args_plot: PlotAPI, df: pd.DataFrame)
+plot_metric(args_plot: PlotAPI, df_metric: pd.DataFrame, bar_criteria: Union[str, List[str]], line_criteria: Union[str, List[str]])
note for DataFramePlot "Updated docstrings to use 'dataframe' instead of 'data frame'"
}
Class diagram for SpectraFit version and deprecation warningclassDiagram
class SpectraFit {
+PYTHON_38_VERSION : tuple
+__version__ : str
+test_version() : None
+test_python_38_warning(monkeypatch: MonkeyPatch) : None
+test_no_warning_for_other_versions(monkeypatch: MonkeyPatch) : None
note for SpectraFit "Added unit tests for version and Python 3.8 deprecation warning"
}
File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Anselmoo - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1641 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 44 45 +1
Lines 4492 4518 +26
=========================================
+ Hits 4492 4518 +26
Flags with carried forward coverage won't be shown. Click here to find out more.
|
All PR-Submissions:
Pull Requests for the same
update/change?
New ✨✨ Feature-Submissions:
Changes to ⚙️ Core-Features:
us to include them?
Summary by Sourcery
Tests: