-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: 🧪 Update cron schedule for weekly poetry bot to run every hour #1516
Conversation
Review changes with SemanticDiff. |
Reviewer's Guide by SourceryThis pull request updates the cron schedule for the weekly poetry bot in the GitHub Actions workflow. The change modifies the execution frequency from weekly to hourly. File-Level Changes
Tips
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Anselmoo - I've reviewed your changes - here's some feedback:
Overall Comments:
- The change from weekly to hourly updates seems quite drastic. Have you considered a more moderate increase, such as daily updates? This could balance the benefits of more frequent updates with the potential risks of system load and instability.
- With more frequent updates, what testing strategy do you have in place to ensure that these updates don't introduce instability or breaking changes? It would be helpful to outline this in the PR description.
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
@@ -2,7 +2,8 @@ name: Weekly Poetry Update | |||
|
|||
on: | |||
schedule: | |||
- cron: '0 0 * * 0' # Runs every Sunday at midnight | |||
# - cron: '0 0 * * 0' # Runs every Sunday at midnight | |||
- cron: '0 * * * *' # Runs every hour |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion (performance): Reconsider the frequency of the cron job
The cron schedule has been changed from weekly to hourly, which seems excessive for a 'Weekly Poetry Update'. This could lead to unnecessary resource consumption and potential rate limiting issues with external services. Consider a less frequent schedule that balances the need for updates with resource efficiency, such as daily or a few times a week. If more frequent updates are indeed necessary, please provide justification and consider the impact on system stability and any external services this job might interact with.
- cron: '0 * * * *' # Runs every hour | |
- cron: '0 0 * * 1' # Runs every Monday at midnight |
@@ -2,7 +2,8 @@ | |||
|
|||
on: | |||
schedule: | |||
- cron: '0 0 * * 0' # Runs every Sunday at midnight | |||
# - cron: '0 0 * * 0' # Runs every Sunday at midnight |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: Remove commented-out code for clarity
The original cron schedule is left in the file as a commented-out line. To improve code clarity and maintainability, consider removing this line entirely if it's no longer needed. If it's kept for reference, add a clear comment explaining why.
# - cron: '0 0 * * 0' # Runs every Sunday at midnight | |
- cron: '0 * * * *' |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1516 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 44 44
Lines 4466 4466
=========================================
Hits 4466 4466
Flags with carried forward coverage won't be shown. Click here to find out more. |
All PR-Submissions:
Pull Requests for the same
update/change?
New ✨✨ Feature-Submissions:
Changes to ⚙️ Core-Features:
us to include them?
Summary by Sourcery
Modify the CI workflow to change the cron schedule for the weekly poetry bot, enabling it to run every hour instead of once a week.
CI: