Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: 🧪 Update cron schedule for weekly poetry bot to run every hour #1516

Merged
merged 1 commit into from
Aug 26, 2024
Merged

ci: 🧪 Update cron schedule for weekly poetry bot to run every hour #1516

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/weekly-poetry-bot.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@ name: Weekly Poetry Update

on:
schedule:
- cron: '0 0 * * 0' # Runs every Sunday at midnight
# - cron: '0 0 * * 0' # Runs every Sunday at midnight
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Remove commented-out code for clarity

The original cron schedule is left in the file as a commented-out line. To improve code clarity and maintainability, consider removing this line entirely if it's no longer needed. If it's kept for reference, add a clear comment explaining why.

Suggested change
# - cron: '0 0 * * 0' # Runs every Sunday at midnight
- cron: '0 * * * *'

- cron: '0 * * * *' # Runs every hour
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (performance): Reconsider the frequency of the cron job

The cron schedule has been changed from weekly to hourly, which seems excessive for a 'Weekly Poetry Update'. This could lead to unnecessary resource consumption and potential rate limiting issues with external services. Consider a less frequent schedule that balances the need for updates with resource efficiency, such as daily or a few times a week. If more frequent updates are indeed necessary, please provide justification and consider the impact on system stability and any external services this job might interact with.

Suggested change
- cron: '0 * * * *' # Runs every hour
- cron: '0 0 * * 1' # Runs every Monday at midnight


jobs:
update-dependencies:
Expand Down
Loading