Feature/button,icon,typography prop업데이트 #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…con,TypographyProp업데이트
Codecov Report
@@ Coverage Diff @@
## develop #56 +/- ##
===========================================
+ Coverage 74.92% 76.49% +1.57%
===========================================
Files 47 47
Lines 662 668 +6
Branches 113 106 -7
===========================================
+ Hits 496 511 +15
+ Misses 77 75 -2
+ Partials 89 82 -7
Continue to review full report at Codecov.
|
GwangjoGong
reviewed
Jul 23, 2021
| return `width: 20px; height: 20px;`; | ||
| case 'lg': | ||
| return `width: 32px; height: 32px`; | ||
| default: |
There was a problem hiding this comment.
P4: 개인적으로 case: 'md'까지 switch로 다뤘으면 좋겠습니다
| disabledColor, | ||
| ...props | ||
| }) => { | ||
| let textColor: CustomColors['textColor']; |
SeungsuKim
reviewed
Jul 23, 2021
| import _ from 'lodash'; | ||
| import colors from '../../styles/colors'; | ||
|
|
||
| // default color : opacity value change |
There was a problem hiding this comment.
P4: Button 디렉토리 내에 정의되어 있고, Button 디렉토리 내에서만 사용되므로 파일명은 colors.ts, 타입 및 변수 명들도 button prefix를 떼도 괜찮지 않을까요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
테크스펙
변경사항
Typography
Icon
sm,md,lg로 3단계가 되었습니다.Button
line이 없어졌습니다.sm,md,lg로 3단계가 되었습니다.사전 확인사항
Pressable컴포넌트에서 모든 Container Styling을 집어넣는 것을 시도해봤으나, 이슈가 있어 작동에 문제가 있었습니다. 복잡한Pressable을 따로 정의해서 사용하면 가능은 해보이나, 불필요한 작업으로 생각되어Container와Pressable을 분리하여 적용했습니다.[React Native] Pressable styling styled-components/styled-components#3228.