Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Feature/button,icon,typography prop업데이트" #57

Conversation

Hemistone
Copy link
Collaborator

Reverts #56

Button의 icon 색상을 지정하여 바꾸는 것에 이슈가 있어 Button에 colorIcon?: boolean (default: true) 옵션을 추가합니다.

@codecov
Copy link

codecov bot commented Jul 25, 2021

Codecov Report

Merging #57 (1013df8) into develop (bfcf6c9) will decrease coverage by 1.57%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #57      +/-   ##
===========================================
- Coverage    76.49%   74.92%   -1.58%     
===========================================
  Files           47       47              
  Lines          668      662       -6     
  Branches       106      113       +7     
===========================================
- Hits           511      496      -15     
- Misses          75       77       +2     
- Partials        82       89       +7     
Impacted Files Coverage Δ
src/atoms/Icon/Icon.tsx 62.50% <0.00%> (-6.74%) ⬇️
src/atoms/Typography/Typography.tsx 75.00% <ø> (ø)
src/atoms/Button/Button.tsx 62.50% <51.16%> (-18.21%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb24889...1013df8. Read the comment docs.

@Hemistone Hemistone closed this Jul 25, 2021
@Hemistone Hemistone deleted the revert-56-feature/Button,Icon,TypographyProp업데이트 branch July 25, 2021 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant