Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy SA with 3 separate app registrations, Fixes #686 #698

Merged
merged 8 commits into from
Jun 6, 2024

Conversation

neelavarshad
Copy link
Contributor

Fixes #686

Creates unique App Registrations for both landing page and admin portal
Associates appropriate App registrations and URI redirects
Added both app registrations to web app config
Added additional Client ID to supporting interface

@neelavarshad neelavarshad merged commit 555bc9f into Azure:main Jun 6, 2024
7 checks passed
Copy link
Contributor

@santhoshb-msft santhoshb-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets review when you get a chance please

$ISADMTApplicationIDProvided = ($ADMTApplicationIDAdmin && $ADMTApplicationIDPortal)

if($ISADMTApplicationIDProvided -eq $null){
Write-Host "🔑 Multi-Tenant App Registrations provided."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can call it , "Login App Registration.."

{
"requestedAccessTokenVersion" : 2
},
"signInAudience" : "AzureADandPersonalMicrosoftAccount",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be single Tenant

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good way to restrict users further. That said, sometimes the individual responsible for actions on the admin portal may not even be part of the tenant hosting the app registrations. In those cases, partner will need to invite the user to the tenant before being able to manage subscriptions.

@@ -96,7 +97,7 @@ public void ConfigureServices(IServiceCollection services)
.AddOpenIdConnect(options =>
{
options.Authority = $"{config.AdAuthenticationEndPoint}/common/v2.0";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should change to /tenantid/ not common

Copy link
Contributor Author

@neelavarshad neelavarshad Jun 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will make this change too if you no longer want multitenant access to the admin portal (comment above)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--sign-in-audience AzureADMYOrg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New App registration for the portal app
3 participants