-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed Admin app to single tenant #715
Conversation
Hi @neelavarshad lets talk more on Monday before we add more or merge this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test complete, all changes are approved.
All tests passed and approved |
@santhoshb-msft I pushed the default set to false. You can validate on this now. |
Hi @neelavarshad I tried to install this branch twice but keeps failing , can you please rerun on your side again |
@bkhabazan Did you see anything like what Santhosh is encountering? @santhoshb-msft I just ran the deployment on my single-tenant-admin branch and it ran through ok |
@neelavarshad I did not see any error messages when running the code. I was able to deploy successfully. |
I just ran again and same issue, lets connect internally to if the script is missing anything |
@santhoshb-msft Please try again with the latest changes I added. Thanks! |
Hi @neelavarshad just checking if the multiple url display issue is fixed? |
@santhoshb-msft This is fixed now |
@neelavarshad have you seen the below by any chance? |
I ran through several tests last week and didn't see anything with MSI. What point of the script is this coming up on? Is it only on my branch you're seeing this? |
Yes @neelavarshad, just running your branch, just before finish |
@santhoshb-msft |
Sure, checking again and will reach out internally |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Tested with new install
- Validate all three-app registration and their redirect uris
- Validated app service setting for both admin portal and customer portal
- Switched single to muliti tenant . for future we might need docs on how to swtich, 3 steps, enble app service flag, switch app reg and add user to knownusers
Updated admin app configs
Changed variable name for checking if app regs are provided