Update RpcFunctionMetadata with more properties #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add two more properties relating to function metadata to the protobuf, along with some clarifying comments that specify what the attributes are supposed to contian.
pragnagopa
reviewed
Aug 11, 2021
| repeated string raw_bindings = 10; | ||
|
|
||
| // Retry Options: string representation of JObject retry options (maxRetryCount, intervals, etc.) | ||
| string retry_options = 11; |
There was a problem hiding this comment.
define new message for retry options - see https://github.com/Azure/azure-functions-language-worker-protobuf/blob/dev/src/proto/FunctionRpc.proto#L327-L336 for an example that was recently added.
pragnagopa
reviewed
Aug 11, 2021
| string retry_options = 11; | ||
|
|
||
| // Configuration Source: string representation of JToken configuration source property in function metadata | ||
| string config_source = 12; |
There was a problem hiding this comment.
can you provide an example of how this would look like? it is better to declare first class messages for complex types to avoid string parsing on both ends
pragnagopa
requested changes
Aug 11, 2021
|
Retry Options are addressed in PRs for configuration source - I do not have a much context - @soninaren might |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Host needs RetryOptions and configuration source information to populate FunctionMetadata, so two more properties have been added to RpcFunctionMetadata to convey this information.
Some clarifying comments have also been added to RpcFunctionMetadata that specify what the attributes are supposed to contain.