Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RpcFunctionMetadata with more properties #57

Closed
wants to merge 2 commits into from
Closed

Update RpcFunctionMetadata with more properties #57

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e392df1
Update FunctionRpc.proto
anandagopal6 Aug 10, 2021
1158694
Merge branch 'dev' into t-anjanan/more-worker-indexing-additions
surgupta-msft Nov 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/proto/FunctionRpc.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,8 +271,14 @@ message RpcFunctionMetadata {
// Function language
string language = 9;

// Raw binding info
// Raw binding info: string of jsonified binding metadata. One string = one binding
repeated string raw_bindings = 10;

// Retry Options: string representation of JObject retry options (maxRetryCount, intervals, etc.)
string retry_options = 11;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

define new message for retry options - see https://github.com/Azure/azure-functions-language-worker-protobuf/blob/dev/src/proto/FunctionRpc.proto#L327-L336 for an example that was recently added.


// Configuration Source: string representation of JToken configuration source property in function metadata
string config_source = 12;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you provide an example of how this would look like? it is better to declare first class messages for complex types to avoid string parsing on both ends

}

// Host tells worker it is ready to receive metadata
Expand Down