Fill poles #42

bagnell · 2012-05-25T00:40:56Z

Fill the poles in screen space.

Create a viewport quad over each pole.
Attach the texture that the tiles were drawn to.
In the fragment shader:
- If the same fragment in the texture was drawn to, discard.
- If the ray through the fragment doesn't intersect the ellipsoid, discard.
- Use the ray/ellipsoid intersection to compute the position, normal and fragment color, similar to how tiles are shaded.

…en they are not covered by streaming imagery.

…reparation for culling tests for the poles.

…d some minor tests.

…l be used in lighting the poles.

Conflicts: Source/Scene/CentralBody.js

…aps because the intensity changed with the zoom level.

pjcozzi · 2012-05-25T20:57:19Z

Looks good, except for a couple of issues:

The north pole is black when zoomed out, then shaded when zoomed in. Is this due to the ground atmosphere turning off? It is only the north pole in the Skeleton, but both poles in the Sandbox, I assume because of the difference in the sun position.
There are cracks between the pole cap and the tiles below it from a horizon view once you cross over the pole.

Also, please update CHANGES.md.

…dinates and window coordinates.

…and remove duplicates from ExtentTessellator.

shunter · 2012-05-30T15:29:23Z

You should use the new Extent object everywhere an extent is used. For example, Tile.extent, Tile.tileXYToExtent, maxExtent in all the TileProviders and CentralBody.

…ace. It seems to be a bug in ANGLE.

pjcozzi · 2012-05-31T12:49:59Z

@bagnell Let me know when this is ready for me to have another look. Also, do you need to test on my AMD card today?

pjcozzi · 2012-05-31T16:46:23Z

Don't forget to update CHANGES.md.

pjcozzi · 2012-05-31T16:47:47Z

Source/Scene/CentralBody.js

+            occluded = (occludeePoint && !state.occluder.isVisible(new BoundingSphere(occludeePoint, 0.0))) || !state.occluder.isVisible(boundingVolume);
+
+            if (frustumCull || occluded) {
+                this._vaNorthPole = this._vaNorthPole && this._vaNorthPole.destroy();


Why destroy the north and south poles here? They use a trivial amount of memory, and it runs the risk of shader recompiles when the poles come in and out of view.

…raw it.

… poles. Tweaked the ExtentTessellator to handle these extents.

bagnell · 2012-05-31T19:17:18Z

I added the final changes based on review. Ready for the merge.

pjcozzi · 2012-05-31T19:43:01Z

Very nice. Merge in master, then I'll merge this back to master.

Conflicts: Source/Core/ExtentTessellator.js Specs/Core/ExtentTessellatorSpec.js

bagnell · 2012-05-31T20:26:48Z

I merged master and fixed the broken tests and examples.

Fill poles

Sensor dome

Merge in v1.38

bagnell added 14 commits May 23, 2012 14:45

Initial submit of implementation to fill the north and south poles wh…

5dd4b85

…en they are not covered by streaming imagery.

Merge branch 'master' into fill_poles

2a07357

Factor out some code from tile and add it to a new extent object in p…

7f9c8e0

…reparation for culling tests for the poles.

Merge branch 'master' into fill_poles

2aea62c

Add frustum and occlusion culling to the poles. Fix some typos and ad…

baa0cff

…d some minor tests.

Factor out common functions in the central body tile shaders that wil…

7bf249f

…l be used in lighting the poles.

Merge branch 'master' into fill_poles

bc87f96

Conflicts: Source/Scene/CentralBody.js

Add lighting to the poles.

fab8a07

Expose color members for the north/south pole.

6ff0683

Make the night color black if there is no night texture.

113defb

Change start intensity of the poles. The poles looked odd with Bing M…

e600c1c

…aps because the intensity changed with the zoom level.

Merge branch 'master' into fill_poles

98e9a50

Fix pole quad computation for horizon views.

0d7ba37

Discard the fragment earlier if possible.

90bb2ee

ghost assigned pjcozzi May 25, 2012

bagnell mentioned this pull request May 25, 2012

Fill holes at the poles #8

Closed

Merge branch 'master' into fill_poles

eb8ebc6

bagnell added 4 commits May 29, 2012 14:54

Move function to compute window coordinates to transforms, add tests.

61a7609

Add agi_inverseProjection automatic uniform test.

951a86e

Add tests for glsl built-in functions that transform between eye coor…

0b077e8

…dinates and window coordinates.

Combine Rectangle and AxisAlignedBoundingRectangle. Add Extent tests …

67fdf56

…and remove duplicates from ExtentTessellator.

bagnell added 5 commits May 30, 2012 14:41

Change pole VA's usage to stream and fix the rectangle spec so it runs.

3048358

Change all extent object literals to use the new Extent object.

9adab0c

Merge branch 'master' into fill_poles

5835cfc

Fix broken tests.

b516447

Add a workaround to the shader used for the ground atmosphere from sp…

b335653

…ace. It seems to be a bug in ANGLE.

pjcozzi reviewed May 31, 2012
View reviewed changes

bagnell added 5 commits May 31, 2012 13:20

Tweak shader to work correctly on AMD.

1d78239

Don't destroy a pole VBO if it is not visible, just don't update or d…

836a489

…raw it.

Changed Extent to accept extents over the international date line and…

b51cc5e

… poles. Tweaked the ExtentTessellator to handle these extents.

Update CHANGES.md

9330963

Merge branch 'master' into fill_poles

4e1e6e4

CHANGES.md tweaks.

b9f1b26

bagnell added 3 commits May 31, 2012 16:15

Merge branch 'master' into fill_poles

aead19e

Conflicts: Source/Core/ExtentTessellator.js Specs/Core/ExtentTessellatorSpec.js

Fix broken tests and examples from merge.

a837301

Change missed test to use Extent.

ffbee3d

pjcozzi added a commit that referenced this pull request May 31, 2012

Merge pull request #42 from AnalyticalGraphicsInc/fill_poles

5726b02

Fill poles

pjcozzi merged commit 5726b02 into master May 31, 2012

mramato added a commit that referenced this pull request Oct 22, 2015

Merge pull request #42 from AnalyticalGraphicsInc/sensorDome

9160e74

Sensor dome

oterral pushed a commit to oterral/cesium that referenced this pull request Oct 31, 2017

Merge pull request CesiumGS#42 from camptocamp/merge_in_v1.38

70e4afb

Merge in v1.38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fill poles #42

Fill poles #42

bagnell commented May 25, 2012

pjcozzi commented May 25, 2012

shunter commented May 30, 2012

pjcozzi commented May 31, 2012

pjcozzi commented May 31, 2012

pjcozzi May 31, 2012

bagnell commented May 31, 2012

pjcozzi commented May 31, 2012

bagnell commented May 31, 2012

Fill poles #42

Fill poles #42

Conversation

bagnell commented May 25, 2012

pjcozzi commented May 25, 2012

shunter commented May 30, 2012

pjcozzi commented May 31, 2012

pjcozzi commented May 31, 2012

pjcozzi May 31, 2012

Choose a reason for hiding this comment

bagnell commented May 31, 2012

pjcozzi commented May 31, 2012

bagnell commented May 31, 2012