Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CSS keyword support #20

Merged
merged 11 commits into from
Mar 7, 2025
Merged

Add CSS keyword support #20

merged 11 commits into from
Mar 7, 2025

Conversation

sasoder
Copy link
Collaborator

@sasoder sasoder commented Feb 26, 2025

Fixes #17

@sasoder sasoder self-assigned this Feb 26, 2025
peschwartz and others added 4 commits February 28, 2025 11:37
@peschwartz
Update testbed to handle CSS keywords and improve coverage #24 (#25)
a0b1132 
Update testbed to use ABSOLUTE and RELATIVE sizes for testing. closes #24
@sasoder
Support CSS font size keywords and tests for iOS #5 #10 (#18)
ae9d941 
Support CSS font size keywords for iOS #5
CSS font size keywords tests for iOS #10
@peschwartz
Add windows CSS keyword support and tests #6 #11 (#22)
786b320 
feat: CSS keyword support for windows. #6

feat: tests added for CSS font support windows, #11
@KlaraLindemalm
Add Cocoa CSS keywords support #3 #8 (#23)
5c8c3f9 
feat: CSS keyword support for cocoa #3

feat: added Cocoa CSS keyword tests #8
This was linked to issues Mar 4, 2025
docs: documentation for Android #12
Closed
docs: documentation for Cocoa #13
Closed
docs: documentation for GTK #14
Closed
docs: documentation for IOS #15
Closed
docs: documentation for Windows #16
Closed
@peschwartz peschwartz changed the title Add CSS keyword constants to Travertino and update core style component Add CSS keyword support Mar 5, 2025
@Jacmol
Gtk/css keywords (#27)
bc95202 
Functionality for managing relative and absolute font size in GTK
test run and pass 
reverting to a non-explosive solution since it doesn't seem to work to use relative font sizes with Pango

closes #4
closes #9
This was unlinked from issues Mar 5, 2025
docs: documentation for Android #12
Closed
docs: documentation for Cocoa #13
Closed
docs: documentation for GTK #14
Closed
docs: documentation for IOS #15
Closed
docs: documentation for Windows #16
Closed
Jacmol
Jacmol approved these changes Mar 7, 2025
View reviewed changes
Copy link
Collaborator

@Jacmol Jacmol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

sasoder
sasoder commented Mar 7, 2025
View reviewed changes
Copy link
Collaborator Author

@sasoder sasoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Only concern for me is the GTK relative font size test.

gtk/tests_backend/fonts.py
assert 8 * scale < int(self.font.get_size() / Pango.SCALE) < 18 * scale
elif expected in RELATIVE_FONT_SIZES:
scale = RELATIVE_FONT_SIZE_SCALE.get(expected, 1.0)
assert 8 * scale < int(self.font.get_size() / Pango.SCALE) < 18 * scale
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be testing the size relative to the parent font size, rather than its own size.

@peschwartz peschwartz merged commit 0f81681 into main Mar 7, 2025
93 of 94 checks passed
carltestar
carltestar reviewed Mar 7, 2025
View reviewed changes
Copy link
Collaborator

@carltestar carltestar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carltestar carltestar carltestar left review comments

@Jacmol Jacmol Jacmol approved these changes

@peschwartz peschwartz peschwartz approved these changes

@KlaraLindemalm KlaraLindemalm Awaiting requested review from KlaraLindemalm

Assignees

@sasoder sasoder

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: general Travertino changes
5 participants
@sasoder @Jacmol @peschwartz @carltestar @KlaraLindemalm