Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add windows CSS keyword support and tests #22

Merged
merged 11 commits into from
Mar 4, 2025

Conversation

peschwartz
Copy link

Added support for CSS keywords resolves #6
Wrote testing for added CSS keywords resolves #11
Ensured 100% coverage
Created update documentation to hopefully pass the pipeline

@peschwartz peschwartz changed the base branch from main to travertino/css-keywords February 27, 2025 16:27
Copy link
Collaborator

@sasoder sasoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Only thing that caught my eye was the changing of 9 to 9.0, did you change it for a reason? Just curious lol
image

Copy link
Collaborator

@KlaraLindemalm KlaraLindemalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good to me!

@peschwartz peschwartz merged commit 786b320 into travertino/css-keywords Mar 4, 2025
41 of 47 checks passed
@KlaraLindemalm KlaraLindemalm deleted the windows/css-keywords-tests branch March 5, 2025 08:34
peschwartz added a commit that referenced this pull request Mar 7, 2025
Add: CSS keyword constants to Travertino and update core style component #17
Update: testbed to handle CSS keywords and improve coverage #24
Add: CSS font size keywords and tests for iOS #5 #10 (#18)
Add: windows CSS keyword support and tests #6 #11 (#22)
Add: Cocoa CSS keywords support and tests #3 #8 (#23)
Add: Gtk css keywords support and tests #4 #9 (#27)
Fix: remove xxxl keywords #29
Docs: add css keywords to style reference (#33)
Add: Android support for CSS font keywords and tests #2 #7 (#28)

----------
Co-authored-by: Phoebe Schwartz <[email protected]>
Co-authored-by: KlaraLindemalm <[email protected]>
Co-authored-by: Jacmol <[email protected]>
Co-authored-by: carltestar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: testing for Windows feat: font definition for Windows
3 participants