forked from beeware/toga
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add windows CSS keyword support and tests #22
Merged
peschwartz
merged 11 commits into
travertino/css-keywords
from
windows/css-keywords-tests
Mar 4, 2025
Merged
Add windows CSS keyword support and tests #22
peschwartz
merged 11 commits into
travertino/css-keywords
from
windows/css-keywords-tests
Mar 4, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sasoder
approved these changes
Mar 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
KlaraLindemalm
approved these changes
Mar 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good to me!
…0-Group22-2025/toga into windows/css-keywords-tests
peschwartz
added a commit
that referenced
this pull request
Mar 7, 2025
Add: CSS keyword constants to Travertino and update core style component #17 Update: testbed to handle CSS keywords and improve coverage #24 Add: CSS font size keywords and tests for iOS #5 #10 (#18) Add: windows CSS keyword support and tests #6 #11 (#22) Add: Cocoa CSS keywords support and tests #3 #8 (#23) Add: Gtk css keywords support and tests #4 #9 (#27) Fix: remove xxxl keywords #29 Docs: add css keywords to style reference (#33) Add: Android support for CSS font keywords and tests #2 #7 (#28) ---------- Co-authored-by: Phoebe Schwartz <[email protected]> Co-authored-by: KlaraLindemalm <[email protected]> Co-authored-by: Jacmol <[email protected]> Co-authored-by: carltestar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for CSS keywords resolves #6
Wrote testing for added CSS keywords resolves #11
Ensured 100% coverage
Created update documentation to hopefully pass the pipeline