-
Notifications
You must be signed in to change notification settings - Fork 730
UTXO-HD for node 10.4 #6170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UTXO-HD for node 10.4 #6170
Conversation
8dc2abd
to
711449b
Compare
c2b2c7e
to
8d533ce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nothing blocking
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding the tracers, everything looks good to me. Just a small follow-up: the file nix/workbench/service/tracing.nix still references Mempool.AttemptingSync and SyncDone, both of which have been removed. This file should be updated accordingly for this branch.
A corresponding maintenance commit will be added to #6187 , as this PR is a prerequisite for 10.4 anyways. |
Description
Implements the changes required for UTxO-HD Consensus feature. See the documentation for an extensive explanation on what changed and the implications.
Checklist
See Runnings tests for more details
CHANGELOG.md
for affected package.cabal
files are updatedhlint
. See.github/workflows/check-hlint.yml
to get thehlint
versionstylish-haskell
. See.github/workflows/stylish-haskell.yml
to get thestylish-haskell
versionghc-8.10.7
andghc-9.2.7
Note on CI
If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.