Skip to content

UTXO-HD for node 10.4 #6170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2025
Merged

UTXO-HD for node 10.4 #6170

merged 1 commit into from
Apr 23, 2025

Conversation

jasagredo
Copy link
Contributor

@jasagredo jasagredo commented Apr 10, 2025

Description

Implements the changes required for UTxO-HD Consensus feature. See the documentation for an extensive explanation on what changed and the implications.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

@jasagredo jasagredo requested review from a team as code owners April 10, 2025 08:38
@jasagredo jasagredo mentioned this pull request Apr 10, 2025
9 tasks
@jasagredo jasagredo force-pushed the utxo-hd-10.4 branch 3 times, most recently from 8dc2abd to 711449b Compare April 16, 2025 09:20
@jasagredo jasagredo force-pushed the utxo-hd-10.4 branch 8 times, most recently from c2b2c7e to 8d533ce Compare April 22, 2025 14:03
Copy link
Contributor

@jorisdral jorisdral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nothing blocking

Copy link
Contributor

@jutaro jutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding the tracers, everything looks good to me. Just a small follow-up: the file nix/workbench/service/tracing.nix still references Mempool.AttemptingSync and SyncDone, both of which have been removed. This file should be updated accordingly for this branch.

@mgmeier
Copy link
Contributor

mgmeier commented Apr 23, 2025

the file nix/workbench/service/tracing.nix still references Mempool.AttemptingSync and SyncDone, both of which have been removed. This file should be updated accordingly for this branch.

A corresponding maintenance commit will be added to #6187 , as this PR is a prerequisite for 10.4 anyways.

@jasagredo jasagredo added this pull request to the merge queue Apr 23, 2025
Merged via the queue into master with commit 12d70e1 Apr 23, 2025
25 checks passed
@jasagredo jasagredo deleted the utxo-hd-10.4 branch April 23, 2025 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants