Skip to content

New Tracing metrics hotfixes; nix LMDB config #6187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 24, 2025
Merged

Conversation

mgmeier
Copy link
Contributor

@mgmeier mgmeier commented Apr 23, 2025

Description

This PR fixes the following faulty metrics for the New Tracing system, addressing the "Known Issues" for the 10.3.1 release:

  • connectionManager_*
  • slotsMissed

Additionally, it adjusts workbench and nix service configs to recent changes in UTxO-HD:

  • LMDB backing store is not configured on the CLI anymore, but via node config.
  • Trace messages removed from UTxO-HD have been removed from workbench

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

@mgmeier mgmeier mentioned this pull request Apr 23, 2025
9 tasks
@Icelandjack Icelandjack force-pushed the new-tracing/fix-metrics branch 7 times, most recently from bafd96f to 3bf1526 Compare April 24, 2025 11:03
@mgmeier mgmeier force-pushed the new-tracing/fix-metrics branch from 3bf1526 to 1bfd7af Compare April 24, 2025 11:56
@mgmeier mgmeier changed the title New Tracing: metrics hotfixes New Tracing metrics hotfixes; nix LMDB config Apr 24, 2025
@mgmeier mgmeier marked this pull request as ready for review April 24, 2025 11:59
@mgmeier mgmeier requested review from a team as code owners April 24, 2025 11:59
Copy link
Contributor

@fmaste fmaste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues here, merge it!

@mgmeier mgmeier force-pushed the new-tracing/fix-metrics branch from 1bfd7af to b63c369 Compare April 24, 2025 13:52
@mgmeier mgmeier added this pull request to the merge queue Apr 24, 2025
@NadiaYvette
Copy link
Contributor

I poked at it & only found background mostly cosmetic things to go on about. That's a seal of approval!

Copy link
Contributor

@NadiaYvette NadiaYvette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big green light!

Merged via the queue into master with commit a8730d1 Apr 24, 2025
23 of 24 checks passed
@mgmeier mgmeier deleted the new-tracing/fix-metrics branch April 24, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants