fix ^ inliner #17949
Merged
fix ^ inliner #17949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
required for the inliner to work, since all of the logic for computing edges is supposed to be handle by the inference step fix #17759
|
can you test the |
|
It's consistently aggravating when you keep merging PR's without tests after being asked directly to add some. Bugs will regress again if we don't have tests for them. |
ranjanan
added a commit
to ranjanan/julia
that referenced
this pull request
Aug 12, 2016
The PR fixed the ^ inliner issue. This test checks whether the correct code_typed output occurs
|
despite the annoying lack of tests, should this be backported? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.