Add test for PR #17949 #17986
Closed
Add test for PR #17949 #17986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PR fixed the ^ inliner issue. This test checks whether the correct code_typed output occurs
tkelman
added
backport pending 0.5
test
|
Thank you! We should stop merging bugfixes without the corresponding tests, but failing that at least catching them quickly and adding the tests for them will do the job. edit: to be backported if #17949 gets backported |
|
This needs to take into account the |
|
bump @ranjanan do you need clarification for how to add the test here? |
|
We no longer have the code that this was supposed to test. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR fixed the ^ inliner issue. This test checks whether the correct
code_typed output occurs. Adds a test for PR #17949 which fixed #17759