multi.jl: worker finalization, remove :cmd, flush worker() info #4167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please ignore this until I have a fix for the flush(Pipe) issue... |
|
You can add flush(::Pipe) as a no-op. There's no buffering going on and as of lately we block the task until the write is done. |
|
Thanks! Done! |
JeffBezanson
added a commit
that referenced
this pull request
Aug 28, 2013
multi.jl: worker finalization, remove :cmd, flush worker() info
IanButterworth
added a commit
that referenced
this pull request
Mar 2, 2025
Stdlib: Pkg URL: https://github.com/JuliaLang/Pkg.jl.git Stdlib branch: master Julia branch: master Old commit: c54ee594d New commit: 60e3185e3 Julia version: 1.13.0-DEV Pkg version: 1.12.0(Does not match) Bump invoked by: @IanButterworth Powered by: [BumpStdlibs.jl](https://github.com/JuliaLang/BumpStdlibs.jl) Diff: JuliaLang/Pkg.jl@c54ee59...60e3185 ``` $ git log --oneline c54ee594d..60e3185e3 60e3185e3 Test fix: handle if tested Pkg is shipped version (#4182) 61115bee7 fix the right temp dir (#4181) 6fa32d5c3 use temp dir on same filesystem for source install (#4180) cf6191bfa Pidlock source and artifact installation. Registry pidlock fixes. (#4168) 2779d42f4 Update toml-files.md (#4177) f5174898e Changed Pkg.test to prioritise julia_args --threads over current process threads (#4141) 14831edf4 enable windows tree_hash checking (#4167) 92595ec67 Add more tests for BinaryBuilder usage (#4156) ``` Co-authored-by: IanButterworth <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flushing here rids us of problems caused by buffering (recent STDOUT IOStream changes?). Additionally, we don't need :cmd anymore with the latest ClusterManagers.jl, and finalization lets us properly clean up after firing up a PBS/Torque or SGE instance (remove temporary working files, processes).