-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Keep acronyms all upper-case #8175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
UdpSocket -> UDPSocket TcpSocket -> TCPSocket IpAddr -> IPAddr
UDPSocket is exported but TCPSocket is not. Should both be exported? |
The reason we don't export TCPSocket is because there's no reason to construct it. In practice though, I think people embedding tcpsockets into their types is reason enough to export it. |
Let's export it for consistency. |
Would some sort of depreciation be relevant for this? |
Unfortunately names are pretty hard to deprecate. Since 0.4 is going to be massively breaking, I think we can maybe just do the rename and packages that want to be 0.3-0.4 portable can just deal with it. Although it might be interesting to have some mechanism for allowing package to use the 0.4 idioms in a way that will continue to work on 0.3. |
An alias for compatibility seems simple and better than nothing. We can also backport the new names as aliases in 0.3.1 so that stable master compatibility becomes less of a hassle. |
+1 I would add |
e448348
to
b4151f6
Compare
So those get removed when we tag 0.5-something wright? |
Keep acronyms all upper-case
After renaming some constants in JuliaLang#8175, it became harder to write the same code to target 0.3.x and 0.4-dev. This PR potentially adds aliases, so that when 0.3.1 gets released, less mainanance intrested package authors can drop support for 0.3.0, and be compatible with both 0.3.1 and 0.4-dev with the same code base, without version conditionals.
Renames TcpSocket, UdpSocket, IpAddr to follow upper case acronym convention in base. #8165