Skip to content
This repository was archived by the owner on Sep 4, 2019. It is now read-only.

Base.TcpServer -> Base.TCPServer #36

Merged
merged 2 commits into from
Sep 24, 2014
Merged

Conversation

astrieanna
Copy link
Contributor

The capitalization seems to have changed in Base. (With no deprecation warning because it's not exported.)

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 719b374 on astrieanna:fixTCPServer into 962e9bb on JuliaWeb:master.

@IainNZ
Copy link
Contributor

IainNZ commented Sep 23, 2014

Was just going to do this :D Its due to JuliaLang/julia#8175, but somehow didn't come up until now... which is odd, because PkgEval should have caught it.

Its only on 0.4 - and I think somehow juliareleases got changed to julia-0.4 too, which has made Travis fail on both version.

@IainNZ
Copy link
Contributor

IainNZ commented Sep 23, 2014

(so the solution would be to put it in an if I guess)

@astrieanna
Copy link
Contributor Author

ok. I was super confused by this working on travis's juliarelease; I can change it to an if.

@IainNZ
Copy link
Contributor

IainNZ commented Sep 23, 2014

Yeah, only reason I noticed was that in the juliareleases run it installed the package to .julia/v0.4/!

Maybe I should try to shift people to putting a versioninfo() call into their Travis

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling b9b14c2 on astrieanna:fixTCPServer into 962e9bb on JuliaWeb:master.

@astrieanna
Copy link
Contributor Author

hey, @IainNZ, I think this is ready to merge, but I don't have write permissions.

@IainNZ
Copy link
Contributor

IainNZ commented Sep 24, 2014

Yes, indeed. I'll give you write permissions too.

IainNZ added a commit that referenced this pull request Sep 24, 2014
Base.TcpServer -> Base.TCPServer
@IainNZ IainNZ merged commit 696f245 into JuliaWeb:master Sep 24, 2014
@IainNZ
Copy link
Contributor

IainNZ commented Sep 24, 2014

If you want them?

@astrieanna
Copy link
Contributor Author

Looks like Keno fixed that for me. :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants