Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Make Rich as default progress bar #10912

Closed
wants to merge 6 commits into from
Closed

Conversation

kaushikb11
Copy link
Contributor

@kaushikb11 kaushikb11 commented Dec 3, 2021

What does this PR do?

Fixes #<issue_number>

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @SeanNaren @kaushikb11

@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2021

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@codecov
Copy link

codecov bot commented Dec 3, 2021

Codecov Report

Merging #10912 (e7b6379) into master (60fe152) will decrease coverage by 3%.
The diff coverage is 100%.

❗ Current head e7b6379 differs from pull request most recent head 90d9a0a. Consider uploading reports for the commit 90d9a0a to get more accurate results

@@            Coverage Diff            @@
##           master   #10912     +/-   ##
=========================================
- Coverage      92%      88%     -3%     
=========================================
  Files         204      177     -27     
  Lines       17357    16494    -863     
=========================================
- Hits        15889    14561   -1328     
- Misses       1468     1933    +465     

@mergify mergify bot removed the has conflicts label Dec 15, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@stale
Copy link

stale bot commented Jan 5, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you need further help see our docs: https://pytorch-lightning.readthedocs.io/en/latest/generated/CONTRIBUTING.html#pull-request or ask the assistance of a core contributor here or on Slack. Thank you for your contributions.

@stale stale bot added the won't fix This will not be worked on label Jan 5, 2022
@awaelchli awaelchli added progress bar: rich and removed won't fix This will not be worked on labels Jan 5, 2022
@awaelchli awaelchli added this to the 1.6 milestone Jan 5, 2022
@mergify mergify bot added the has conflicts label Feb 7, 2022
@daniellepintz
Copy link
Contributor

If this is still a work in progress, do you want to mark it as a draft?

@kaushikb11 kaushikb11 marked this pull request as draft February 22, 2022 15:19
@carmocca carmocca removed this from the 1.6 milestone Mar 28, 2022
@stale
Copy link

stale bot commented Apr 16, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you need further help see our docs: https://pytorch-lightning.readthedocs.io/en/latest/generated/CONTRIBUTING.html#pull-request or ask the assistance of a core contributor here or on Slack. Thank you for your contributions.

@stale stale bot added the won't fix This will not be worked on label Apr 16, 2022
@stale
Copy link

stale bot commented Apr 21, 2022

This pull request is going to be closed. Please feel free to reopen it create a new from the actual master.

@stale stale bot closed this Apr 21, 2022
@carmocca carmocca deleted the rich/default branch April 21, 2022 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants