[WIP] Make RichProgressBar the default if rich is available #15321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awaelchli
requested review from
carmocca,
rohitgr7,
otaj,
justusschock and
Borda
as code owners
awaelchli
added
progress bar: rich
bug
This was referenced Oct 28, 2022
awaelchli
changed the title
Borda
approved these changes
Nov 1, 2022
carmocca
reviewed
Nov 2, 2022
| @@ -174,7 +178,7 @@ def _configure_progress_bar(self, enable_progress_bar: bool = True) -> None: | |||
| ) | |||
|
|
|||
| if enable_progress_bar: | |||
| progress_bar_callback = TQDMProgressBar() | |||
| progress_bar_callback = RichProgressBar() if _RICH_AVAILABLE else TQDMProgressBar() | |||
There was a problem hiding this comment.
I'm hesitant of this change for two reasons:
- Rich pbar is slower than tqdm (there's an issue about this somewhere, cc @akihironitta)
- I believe CI installs rich, which means that now tqdm is untested. Since it's the most widely used, I find that risky.
|
Shouldn't this be labeled as "feature" and not "bug"? Also I added "breaking change", as users might be expecting tqdm even if they have rich installed in their environments |
|
Sorry everyone. This PR was initially just used to reveal bugs that were fixed in the linked PRs. Since jobs don't run on drafts, I had to mark it ready. But the PR is actually not ready for review. It is merely a proof of concept. There are many open questions regarding
that need to be discussed first before we can make the switch. |
awaelchli
changed the title
awaelchli
added
feature
Borda
requested review from
carmocca
and removed request for
otaj and
rohitgr7
|
@awaelchli could you check this one if you have time :) |
|
I currently don't have the capacity to pursue this further. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Continues #10912, #9647
Fixes #9580
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
I made sure I had fun coding 🙃
cc @Borda @justusschock @kaushikb11 @rohitgr7