Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unnecessary try! in MockOutput conformances #1

Closed
roanutil opened this issue Aug 9, 2022 · 1 comment
Closed

Unnecessary try! in MockOutput conformances #1

roanutil opened this issue Aug 9, 2022 · 1 comment

Comments

@roanutil
Copy link
Member

roanutil commented Aug 9, 2022

NetworkService/Sources/NetworkServiceTestHelper/MockNetworkService.swift

Line 133 in 026a453

.success(try! encoder.encode(value))

NetworkService/Sources/NetworkServiceTestHelper/MockNetworkService.swift

Line 153 in 026a453

let data = try! Self.encoder.encode(self)

roanutil added a commit that referenced this issue Nov 15, 2022
@roanutil
Remove unnecessary use of try!. Resolves issue #1.
345d29e 
feature/stop-schemes-from-polluting-dependents
roanutil added a commit that referenced this issue Nov 15, 2022
@roanutil
Merge pull request #5 from MFB-Technologies-Inc/feature/stop-schemes-…
c8ffdc2 
…from-polluting-dependents

- Add .swiftpm to gitignore to stop schemes from polluting packages that depend on NetworkService
- Run swiftformat
- Update ci.yml to use newer codecov flow
- Add codecov badge to README
- Remove unnecessary use of `try!`. Resolves issue #1.
- Add missing assertion descriptions in tests. Resolves swiftlint warnings.
@roanutil
Copy link
Member Author

Resolved in PR #5

@roanutil roanutil mentioned this issue Nov 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@roanutil