Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .swiftpm to gitignore to stop schemes from polluting packages that depend on NetworkService #5

Merged
merged 6 commits into from
Nov 15, 2022

Conversation

roanutil
Copy link
Member

@roanutil roanutil commented Nov 14, 2022

  • Add .swiftpm to gitignore to stop schemes from polluting packages that depend on NetworkService
  • Run swiftformat
  • Update ci.yml to use newer codecov flow
  • Add codecov badge to README
  • Remove unnecessary use of try!. Resolves issue Unnecessary try! in MockOutput conformances #1.
  • Add missing assertion descriptions in tests. Resolves swiftlint warnings.

feature/stop-schemes-from-polluting-dependents

…t depend on NetworkService

feature/stop-schemes-from-polluting-dependents
feature/stop-schemes-from-polluting-dependents
feature/stop-schemes-from-polluting-dependents
@roanutil roanutil temporarily deployed to default November 14, 2022 16:51 Inactive
@roanutil roanutil temporarily deployed to default November 14, 2022 16:51 Inactive
@roanutil roanutil temporarily deployed to default November 14, 2022 16:51 Inactive
@roanutil roanutil temporarily deployed to default November 14, 2022 16:51 Inactive
@roanutil roanutil temporarily deployed to default November 14, 2022 16:51 Inactive
feature/stop-schemes-from-polluting-dependents
@roanutil roanutil temporarily deployed to default November 14, 2022 16:57 Inactive
@roanutil roanutil temporarily deployed to default November 14, 2022 16:57 Inactive
@roanutil roanutil temporarily deployed to default November 14, 2022 16:57 Inactive
@roanutil roanutil temporarily deployed to default November 14, 2022 16:57 Inactive
@roanutil roanutil temporarily deployed to default November 14, 2022 16:57 Inactive
feature/stop-schemes-from-polluting-dependents
…ngs.

feature/stop-schemes-from-polluting-dependents
@roanutil roanutil temporarily deployed to default November 15, 2022 18:02 Inactive
@roanutil roanutil temporarily deployed to default November 15, 2022 18:02 Inactive
@roanutil roanutil temporarily deployed to default November 15, 2022 18:12 Inactive
@roanutil roanutil temporarily deployed to default November 15, 2022 18:12 Inactive
@roanutil roanutil temporarily deployed to default November 15, 2022 18:12 Inactive
@roanutil roanutil temporarily deployed to default November 15, 2022 18:12 Inactive
@roanutil roanutil temporarily deployed to default November 15, 2022 18:12 Inactive
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@036aaf9). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main       #5   +/-   ##
=======================================
  Coverage        ?   75.22%           
=======================================
  Files           ?       50           
  Lines           ?     1534           
  Branches        ?        0           
=======================================
  Hits            ?     1154           
  Misses          ?      380           
  Partials        ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@roanutil roanutil merged commit c8ffdc2 into main Nov 15, 2022
@roanutil roanutil deleted the feature/stop-schemes-from-polluting-dependents branch November 15, 2022 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants