Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(videoViewport): Resolve Cine Player Faults on DisplaySet Update #4909

Merged
merged 8 commits into from
Apr 4, 2025

Conversation

pedrokohler
Copy link
Collaborator

@pedrokohler pedrokohler commented Apr 1, 2025

Context

Fixes: #4908

Changes & Results

Before:

Screenshare.-.2025-04-01.2_37_03.PM.mp4

After:

Screenshare.-.2025-04-01.2_40_26.PM.mp4

Testing

Checklist

PR

  • [] My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • [] My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • [] The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • [] OS:
  • [] Node version:
  • [] Browser:

Copy link

netlify bot commented Apr 1, 2025

Deploy Preview for ohif-dev ready!

Name Link
🔨 Latest commit a7d5977
🔍 Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/67f0144a2409f9000805ce70
😎 Deploy Preview https://deploy-preview-4909--ohif-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 1, 2025

Deploy Preview for ohif-platform-docs failed. Why did it fail? →

Name Link
🔨 Latest commit a7d5977
🔍 Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/67f0144a558a570008a926ee

@pedrokohler pedrokohler requested a review from sedghi April 1, 2025 17:44
@pedrokohler pedrokohler requested a review from sedghi April 1, 2025 18:50
Copy link
Member

@sedghi sedghi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@sedghi sedghi changed the title fix: pilling up cines fix(videoViewport): Resolve Cine Player Faults on DisplaySet Update Apr 4, 2025
@sedghi sedghi merged commit 746f252 into OHIF:master Apr 4, 2025
12 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Cine "pilles up" when playing and video viewport is updated
2 participants