Skip to content

fix(videoViewport): Resolve Cine Player Faults on DisplaySet Update #4909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 4, 2025
Merged

fix(videoViewport): Resolve Cine Player Faults on DisplaySet Update #4909

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
148f142
fix: pilling up cines
pedrokohler Apr 1, 2025
f6e4ea7
feat: use command instead of viewportGridService's setDisplaySetsForV…
pedrokohler Apr 1, 2025
94b0e17
fix: accessing undefined frameRate
pedrokohler Apr 1, 2025
e689afe
Merge branch 'master' into fix-pilling-up-cines
pedrokohler Apr 1, 2025
4e55cb6
fix: remove contexts
pedrokohler Apr 2, 2025
11f1f6a
Merge branch 'master' of github.com:OHIF/Viewers into fix-pilling-up-…
pedrokohler Apr 4, 2025
6b35308
refactor: use simplified run command call
pedrokohler Apr 4, 2025
a7d5977
Merge branch 'master' into fix-pilling-up-cines
pedrokohler Apr 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions platform/core/src/services/ViewportGridService/ViewportGridService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,14 +184,27 @@ class ViewportGridService extends PubSubService {
this.setDisplaySetsForViewports([props]);
}

public async setDisplaySetsForViewports(props) {
await this.serviceImplementation._setDisplaySetsForViewports(props);
public async setDisplaySetsForViewports(viewportsToUpdate) {
const { cineService } = this.servicesManager.services;
await this.serviceImplementation._setDisplaySetsForViewports(viewportsToUpdate);
const state = this.getState();
const updatedViewports = [];

const removedViewportIds = [];

for (const viewport of props) {
// Stopping the cine of modified viewports before changing the viewports to
// avoid inconsistent state and lost references
viewportsToUpdate.forEach(viewport => {
const state = cineService.getState();
const currentCineState = state.cines?.[viewport.viewportId];
cineService.setCine({
id: viewport.viewportId,
frameRate: currentCineState?.frameRate ?? state.default.frameRate,
isPlaying: false,
});
});

for (const viewport of viewportsToUpdate) {
const updatedViewport = state.viewports.get(viewport.viewportId);

if (updatedViewport) {
Expand Down