Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the user option to select NMEA sentences #778

Merged
merged 2 commits into from
Aug 11, 2022

Conversation

b-reyes
Copy link
Contributor

@b-reyes b-reyes commented Aug 10, 2022

In this PR I address #580. This PR removes the option that allows the user to select a subset of the GPS position sentences. It then ensures that we only select the NMEA sentences: ["GGA", "GLL", "RMC"] .

@b-reyes b-reyes added this to the 0.6.2 milestone Aug 10, 2022
@b-reyes b-reyes requested a review from leewujung August 10, 2022 21:18
Copy link
Member

@leewujung leewujung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@b-reyes : Thanks for the PR! Everything looks good and it's ready to be merged.

I only have a minor request: could you rename set_group_base._parse_NMEA() to something like _extract_NMEA_latlon() so that the function name describes more precisely the operations?

Feel free to merge afterwards. Thanks!

@codecov-commenter
Copy link

codecov-commenter commented Aug 11, 2022

Codecov Report

Merging #778 (bd0273f) into dev (a020d71) will decrease coverage by 7.22%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev     #778      +/-   ##
==========================================
- Coverage   82.38%   75.16%   -7.23%     
==========================================
  Files          48       15      -33     
  Lines        4264     2416    -1848     
==========================================
- Hits         3513     1816    -1697     
+ Misses        751      600     -151     
Flag Coverage Δ
unittests 75.16% <100.00%> (-7.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
echopype/convert/api.py 84.55% <ø> (-0.23%) ⬇️
echopype/convert/set_groups_base.py 88.42% <100.00%> (-2.01%) ⬇️
echopype/convert/set_groups_ek60.py 92.03% <100.00%> (ø)
echopype/convert/set_groups_ek80.py 96.57% <100.00%> (ø)
echopype/convert/utils/ek_raw_parsers.py 54.90% <0.00%> (-0.17%) ⬇️
echopype/echodata/widgets/widgets.py
echopype/utils/prov.py
...echodata/sensor_ep_version_mapping/v05x_to_v06x.py
... and 30 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@b-reyes b-reyes merged commit 0e22633 into OSOceanAcoustics:dev Aug 11, 2022
@b-reyes b-reyes deleted the rem-nmea-sel branch August 23, 2022 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants