Remove the user option to select NMEA sentences

echopype/convert/api.py

@@ -25,8 +25,6 @@
 
 DEFAULT_CHUNK_SIZE = {"range_sample": 25000, "ping_time": 2500}
 
-NMEA_SENTENCE_DEFAULT = ["GGA", "GLL", "RMC"]
-
 BEAM_SUBGROUP_DEFAULT = "Beam_group1"
 
 
@@ -238,9 +236,6 @@ def _set_convert_params(param_dict: Dict[str, str]) -> Dict[str, str]:
 
     The default set of parameters include:
     - Platform group: ``platform_name``, ``platform_type``, ``platform_code_ICES``, ``water_level``
-    - Platform/NMEA: ``nmea_gps_sentence``,
-                     for selecting specific NMEA sentences,
-                     with default values ['GGA', 'GLL', 'RMC'].
     - Top-level group: ``survey_name``
 
     Other parameters will be saved to the top level.
@@ -261,7 +256,6 @@ def _set_convert_params(param_dict: Dict[str, str]) -> Dict[str, str]:
     out_params["platform_code_ICES"] = param_dict.get("platform_code_ICES", "")
     out_params["platform_type"] = param_dict.get("platform_type", "")
     out_params["water_level"] = param_dict.get("water_level", None)
-    out_params["nmea_gps_sentence"] = param_dict.get("nmea_gps_sentence", NMEA_SENTENCE_DEFAULT)
 
     # Parameters for the Top-level group
     out_params["survey_name"] = param_dict.get("survey_name", "")

echopype/convert/set_groups_base.py

@@ -11,6 +11,8 @@
 
 DEFAULT_CHUNK_SIZE = {"range_sample": 25000, "ping_time": 2500}
 
+NMEA_SENTENCE_DEFAULT = ["GGA", "GLL", "RMC"]
+
 
 class SetGroupsBase(abc.ABC):
     """Base class for saving groups to netcdf or zarr from echosounder data files."""
@@ -143,10 +145,10 @@ def set_vendor(self) -> xr.Dataset:
         raise NotImplementedError
 
     # TODO: move this to be part of parser as it is not a "set" operation
-    def _parse_NMEA(self):
+    def _extract_NMEA_latlon(self):
         """Get the lat and lon values from the raw nmea data"""
         messages = [string[3:6] for string in self.parser_obj.nmea["nmea_string"]]
-        idx_loc = np.argwhere(np.isin(messages, self.ui_param["nmea_gps_sentence"])).squeeze()
+        idx_loc = np.argwhere(np.isin(messages, NMEA_SENTENCE_DEFAULT)).squeeze()
         if idx_loc.size == 1:  # in case of only 1 matching message
             idx_loc = np.expand_dims(idx_loc, axis=0)
         nmea_msg = []

echopype/convert/set_groups_ek60.py

@@ -218,7 +218,7 @@ def set_platform(self, NMEA_only=False) -> xr.Dataset:
 
         # Collect variables
         # Read lat/long from NMEA datagram
-        time1, msg_type, lat, lon = self._parse_NMEA()
+        time1, msg_type, lat, lon = self._extract_NMEA_latlon()
 
         # NMEA dataset: variables filled with nan if do not exist
         ds = xr.Dataset(

echopype/convert/set_groups_ek80.py

@@ -228,7 +228,7 @@ def set_platform(self) -> xr.Dataset:
             water_level = np.nan
             print("WARNING: The water_level_draft was not in the file. " "Value set to NaN.")
 
-        time1, msg_type, lat, lon = self._parse_NMEA()
+        time1, msg_type, lat, lon = self._extract_NMEA_latlon()
         time2 = self.parser_obj.mru.get("timestamp", None)
         time2 = np.array(time2) if time2 is not None else [np.nan]