Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add a maven plugin #278

Merged
merged 5 commits into from
Nov 14, 2021
Merged

feat: add a maven plugin #278

merged 5 commits into from
Nov 14, 2021

Conversation

misterjoshua
Copy link
Collaborator

@misterjoshua misterjoshua commented Nov 11, 2021 •
edited
Loading

This PR adds a maven plugin that allows users to diff openapi specs with Maven and detect breaking changes during builds.

Fixes #152
See also wheatstalk/openapi-diff-maven-plugin/152

@misterjoshua misterjoshua marked this pull request as draft November 11, 2021 18:04
@misterjoshua
Copy link
Collaborator Author

@joschi Hey. I've created this draft PR so that we can better understand the work needed to merge wheatstalk/openapi-diff-maven-plugin per your issue.

@misterjoshua misterjoshua marked this pull request as ready for review November 14, 2021 19:07
@misterjoshua misterjoshua requested a review from joschi November 14, 2021 19:07
@misterjoshua
Copy link
Collaborator Author

@joschi Hey. I made some small adjustments to this PR and I'm ready for review. Let me know whether you have any changes or suggestions. Thanks.

@joschi joschi added this to the 2.0.0 milestone Nov 14, 2021
joschi
joschi approved these changes Nov 14, 2021
View reviewed changes
Copy link
Contributor

@joschi joschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@misterjoshua Thanks a lot for the quick response to my request in your repository. ❤️

The pull request looks good to me. Thanks for also adding the new section in the README.md file. 😄

Would you please add yourself to the developers section in the Parent POM?

openapi-diff/pom.xml

Lines 24 to 34 in 7d1cf29

<developers>
<developer>
<name>qdesrame</name>
<email>[email protected]</email>
</developer>
<developer>
<name>Jochen Schalanda</name>
<email>[email protected]</email>
<url>https://github.com/joschi</url>
</developer>
</developers>

After that you can merge the pull request if you don't want to change anything else in it and we can release another beta version, and then finally version 2.0.0 of OpenAPI Diff.

@misterjoshua misterjoshua merged commit 4a91cae into OpenAPITools:master Nov 14, 2021
@misterjoshua misterjoshua deleted the add-maven branch November 14, 2021 22:12
joschi pushed a commit that referenced this pull request Nov 16, 2021
@kubamarchwicki
Fix packaging of Maven plugin (#287)
bf26b65 
* Change packaging to maven-plugin
* Minimal maven-plugin example
* Fix the new spec location

Refs #278
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joschi joschi joschi approved these changes

Assignees

@misterjoshua misterjoshua

Labels
enhancement
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

Provide a maven plugin
2 participants
@misterjoshua @joschi