Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix redundant install of cblas_test.h #499

Merged
merged 1 commit into from
Apr 6, 2021

Conversation

epsilon-0
Copy link
Contributor

Signed-off-by: Aisha Tammy [email protected]


I'm hoping to fix the names of the header files, so that standard 32bit and extended 64 bit can be installed simultaneously.
This is a small step towards that, shouldn't have any regressions.
All tests are passing.

@codecov
Copy link

codecov bot commented Feb 26, 2021

Codecov Report

Merging #499 (0095825) into master (8bc7b0a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #499   +/-   ##
=======================================
  Coverage   83.33%   83.33%           
=======================================
  Files        1820     1820           
  Lines      170857   170857           
=======================================
  Hits       142384   142384           
  Misses      28473    28473           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bc7b0a...0095825. Read the comment docs.

@weslleyspereira
Copy link
Collaborator

Hi @epsilon-0. Thanks for work on this fix! Do you know if the Makefile version needs any updates too? I am planning to soon propose a PR that adds Makefile on Travis CI.

@epsilon-0
Copy link
Contributor Author

I am unsure, I haven't used the Makefile version.
I can take a look tonight.

@weslleyspereira
Copy link
Collaborator

Thanks! :)

@weslleyspereira
Copy link
Collaborator

Hi @epsilon-0. Thanks for work on this fix! Do you know if the Makefile version needs any updates too? I am planning to soon propose a PR that adds Makefile on Travis CI.

I made it! Look at #500. Also, PR #507 has included some new targets on Travis CI, and #508 is doing the same.

@weslleyspereira weslleyspereira added this to the LAPACK 3.10.0 milestone Mar 25, 2021
@langou langou merged commit acbf970 into Reference-LAPACK:master Apr 6, 2021
christoph-conrads pushed a commit to christoph-conrads/lapack that referenced this pull request May 23, 2021
fix redundant install of cblas_test.h
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants