Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try makefile on travis ci #500

Merged

Conversation

weslleyspereira
Copy link
Collaborator

Add tests for the Makefile build system using make.inc.example on Travis CI. Tests performed on both Linux and Mac OS

@langou
Copy link
Contributor

langou commented Mar 1, 2021

Thanks @weslleyspereira. That's a really good idea.

@codecov
Copy link

codecov bot commented Mar 1, 2021

Codecov Report

Merging #500 (d0deb4b) into master (8bc7b0a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #500   +/-   ##
=======================================
  Coverage   83.33%   83.33%           
=======================================
  Files        1820     1820           
  Lines      170857   170857           
=======================================
  Hits       142384   142384           
  Misses      28473    28473           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bc7b0a...d0deb4b. Read the comment docs.

@weslleyspereira
Copy link
Collaborator Author

This PR should be ready for review. It mitigates the inconsistencies between the Makefile and CMake build systems reported in #488.

In this PR we have:

  1. Travis CI working for both CMake and Makefile default configurations.
  2. Compatible compilation flags in these two builds systems.

This PR does not modify the Meson build system.

@langou
Copy link
Contributor

langou commented Mar 1, 2021

I think we are ready to retire the Meson build system. Thumbs up to this post if you think we should retire the Meson build system. Thumbs down if you think we should keep the Meson build system.

@weslleyspereira weslleyspereira mentioned this pull request Mar 1, 2021
@langou langou merged commit 4b11516 into Reference-LAPACK:master Mar 2, 2021
christoph-conrads pushed a commit to christoph-conrads/lapack that referenced this pull request May 23, 2021
…file-on-Travis-CI

Try makefile on travis ci
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants