Skip to content

RCML Downloader logging does not provide adequate information #2178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
otsakir opened this issue Jun 1, 2017 · 2 comments
Closed

RCML Downloader logging does not provide adequate information #2178

otsakir opened this issue Jun 1, 2017 · 2 comments

Comments

@otsakir
Copy link
Contributor

otsakir commented Jun 1, 2017

When downloader fails to retrieve/parse RCML from a source the exception thrown does not provide enough information in the log to troubleshoot the problem. It's like the following:

 [org.restcomm.connect.http.client.Downloader] (RestComm-akka.actor.default-dispatcher-1425) 
Problem while trying to download RCML javax.xml.stream.XMLStreamException: Error parsing the 
RCML:org.xml.sax.SAXParseException; lineNumber: 1; columnNumber: 1; Content is not allowed in 
prolog.

We could include the following:

  1. HTTP return status code
  2. URL that was supposed to return proper RCML
  3. Small part of the response to get a clue of what went wrong. 50-100 chars only.
@deruelle
Copy link
Member

deruelle commented Jun 1, 2017

We should also probably send a notification back to the developer so he can be notified something is wrong with his application

@otsakir
Copy link
Contributor Author

otsakir commented Jun 13, 2017

I'm closing this issue but it's not merged yet. There is another requirement for adding one more notification in case download fails which will be taken care of in another issue, in another sprint.

@otsakir otsakir closed this as completed Jun 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants