Skip to content

Issue2178 better downloader logging #2213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 15, 2017

Conversation

otsakir
Copy link
Contributor

@otsakir otsakir commented Jun 9, 2017

Added more verbose logging when Downloader throws an error. Testsuite has been run locally with no major findings but at the same time comparing results with master branch has not been consistent.

This is about #2178

@maria-farooq
Copy link

maria-farooq commented Jun 12, 2017

@otsakir just a side comment on RCML download failure.
If download fails with http status notFound then, i see VI adds/sends notification.
otherwise call fails.

@gvagenas @deruelle do you think a notification should be added/sent in case of other failures as well (other than NotFound)

i am discussing RCML download failure.
now there can be many reason for above failure.

  1. = NOTFOUND
  2. = AnythingElse
    both are RCML download failure.
    currently we only add/send notification for case 1.

@maria-farooq
Copy link

Quoting @gvagenas [12:22 PM]

Oh I see your point. I agree, we should add notification for (2) also.

@otsakir do you think we can sample notification code like we have for case 1 in case 2 as well or you think its too much (in that case we can create a separate issue)

@maria-farooq maria-farooq merged commit a32db8c into master Jun 15, 2017
@jaimecasero jaimecasero deleted the issue2178_better_downloader_logging branch November 21, 2017 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants