fix: leader banner visible in new navigation #35417
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 3129953 The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #35417 +/- ##
========================================
Coverage 59.66% 59.67%
========================================
Files 2826 2826
Lines 68378 68357 -21
Branches 15149 15142 -7
========================================
- Hits 40800 40793 -7
+ Misses 24964 24951 -13
+ Partials 2614 2613 -1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
aleksandernsilva
requested changes
Mar 6, 2025
abhinavkrin
force-pushed
the
fix/leader-banner-visible-in-new-navigation
branch
from
16aa8c3 to
cc7cdce
Compare
|
Signed-off-by: Abhinav Kumar <[email protected]>
Signed-off-by: Abhinav Kumar <[email protected]>
Signed-off-by: Abhinav Kumar <[email protected]>
abhinavkrin
force-pushed
the
fix/leader-banner-visible-in-new-navigation
branch
from
cc7cdce to
3454617
Compare
|
@kody start-review |
Code Review Completed! 🔥The code review was successfully completed based on your current configurations. Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
![kodus-ai[bot]](https://avatars.githubusercontent.com/in/413034?s=60&v=4){kind=small}
MarcosSpessatto
approved these changes
Mar 14, 2025
aleksandernsilva
approved these changes
Mar 17, 2025
scuciatto
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Currently, the "Leader" role is displayed in the room header when using the new navigation, instead of being removed.
This PR removes the leader banner from the chat header in new navigation.
Screen.Recording.2025-03-12.at.6.14.28.PM.mov
Issue(s)
Steps to test or reproduce
Further comments
CORE-1013
This pull request addresses the issue of the room leader banner being visible in the new navigation of Rocket.Chat. The changes include the removal of the room leader banner from the chat header and the elimination of leader banner functionality, room roles, and real name settings in the
RoomBody.tsxfile. Additionally, theRoomBodyV2.tsxfile has been simplified by removing unnecessary merged refs and directly usingwrapperRef. TheRoomTopic.tsxcomponent has been streamlined by removing room leader functionality and unnecessary dependencies, while retaining the core topic display and edit capabilities. Furthermore, theuseBannerSection.tshook has been refactored to improve variable naming and conditional checks for banner section visibility logic.