Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix showcase target overlay at wrong position #347

Closed

Conversation

luccasclezar
Copy link

Description

Doing some debugging I saw that the target overlay was being laid out starting from the center of the target. I fixed it simply by subtracting half the size from the offset.

I kept the FractionalTranslation there anyway because I didn't want to break anything, but now it only translates when size is null.

Fixes #346 Dont respond to any clicks in target

@vatsaltanna
Copy link
Collaborator

Hi @luccasclezar, The issue that you have mentioned in the PR doesn't have the issue with positioning, it's an issue of IgnorePointer widget which has been fixed in PR #351 and it will be available in the new release version so closing this PR for now Thanks for your contribution and support in the issue we really appreciate this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dont respond to any clicks in target
2 participants