fix: 🐛 #346 Don't respond to any clicks in target & #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ujas-m-simformsolutions
approved these changes
Mar 7, 2023
#348 showcaseview after upgrade to flutter 3.7.1 not disable target click
vatsaltanna
force-pushed
the
fix/issue-346
branch
from
97b6c28 to
a353be6
Compare
satria-wardana
added a commit
to satria-wardana/flutter_showcaseview
that referenced
this pull request
Sep 7, 2023
* master: (55 commits) 📝 Update CHANGELOG.md file for version 2.0.3. (SimformSolutionsPvtLtd#368) feat: ✨ Add callback when barrier has been clicked (SimformSolutionsPvtLtd#359) fixed-child-constructor-invocation (SimformSolutionsPvtLtd#361) ✨ (SimformSolutionsPvtLtd#148) Add feasibility to add `textDirection` of `title` and `description`. (SimformSolutionsPvtLtd#356) fix: 🐛 SimformSolutionsPvtLtd#346 Don't respond to any clicks in target & (SimformSolutionsPvtLtd#351) fix: 🐛 Flutter inspector makes screen grey (SimformSolutionsPvtLtd#353) 🔖 version bump 2.0.0+1 to 2.0.1 (SimformSolutionsPvtLtd#341) fix: 🐛 Take in account view insets (such as keyboard) (SimformSolutionsPvtLtd#288) Miscellaneous changes Add missing copyright notice in enum.dart feat: ✨ Add padding to title and description fix: 🐛 PR title validation workflow issue (SimformSolutionsPvtLtd#322) feat: ✨ Provide Manual option for vertical position of tooltip (SimformSolutionsPvtLtd#306) feat: ✨ Enable/disable showcase globally. (SimformSolutionsPvtLtd#319) ✨ add mac support in example. (SimformSolutionsPvtLtd#197) Fix: 🔨 Remove title validation workflow (SimformSolutionsPvtLtd#321) chore: 👷workflow for PR title validation (SimformSolutionsPvtLtd#286) release: 🔖 version bump 2.0.0 to 2.0.0+1 (SimformSolutionsPvtLtd#302) release: 🔖 version bump 1.1.8 to 2.0.0 (SimformSolutionsPvtLtd#301) fix: 🐛 logic update in `tooltip_widget.dart` (SimformSolutionsPvtLtd#300) ... # Conflicts: # example/ios/Flutter/AppFrameworkInfo.plist # example/ios/Runner.xcodeproj/project.pbxproj # example/lib/main.dart # lib/src/showcase.dart # lib/src/showcase_widget.dart # lib/src/tooltip_widget.dart
LocLt-Mobile
pushed a commit
to guide-inc-org/guide-flutter_showcaseview
that referenced
this pull request
Oct 28, 2023
…et & (SimformSolutionsPvtLtd#351) SimformSolutionsPvtLtd#348 showcaseview after upgrade to flutter 3.7.1 not disable target click
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#348 showcaseview after upgrade to flutter 3.7.1 not disable target click
Description
We have used
ignorePointerwidget to ignore the default gesture added in showcase view. in the code refactore PR #325 we have usedignoringflag inignorePointerwidget to determine if default gesture should be ignored or not but somehow whenignoringflag is false thenignorePointerwidget send the gesture event to target widgets when this should not be the case. instead of usingignoringflag if we unwrap the targetwidget with ignorePointer widget solves the issue.Checklist
fix:,feat:,docs:etc).docsand added dartdoc comments with///.examplesordocs.Breaking Change?
Related Issues
#346 Don't respond to any clicks in target
#348 showcaseview after upgrade to flutter 3.7.1 not disable target click