Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable test generation for Kotlin getters/setters #911 #1003

Merged

Conversation

volivan239
Copy link
Collaborator

Description

This PR disables test generation for Kotlin getters/setters in plugin. Currently, overridden getters/setters are not tested as well as default ones (generated by Kotlin), but as discussed with @korifey, we take this as the expected behavior.

Fixes #911

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Manual Scenario

Launch plugin on any class with properties -- getters/setters won't be proposed for testing (e.g. for the class from #911 the test action is disabled).

Checklist (remove irrelevant options):

This is the author self-check list

  • The change followed the style guidelines of the UTBot project
  • Self-review of the code is passed
  • The change contains enough commentaries, particularly in hard-to-understand areas
  • New documentation is provided or existed one is altered
  • No new warnings
  • New tests have been added
  • All tests pass locally with my changes

@volivan239 volivan239 marked this pull request as ready for review September 23, 2022 14:38
@volivan239 volivan239 enabled auto-merge (squash) September 23, 2022 15:11
@volivan239 volivan239 merged commit d171955 into main Sep 23, 2022
@volivan239 volivan239 deleted the volivan239/disabling_tests_for_kotlin_getters_setters branch September 23, 2022 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autogenerated Kotlin getters/setters shouldn't be tested
2 participants