Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in filtering Kotlin getters/setters in plugin #1026

Merged
merged 1 commit into from
Sep 28, 2022

Conversation

volivan239
Copy link
Collaborator

Description

Filtering Kotlin getters/setters in plugin was added in #1003, however, there was a major bug in that fix (filter was checking condition that was always true).

Fixes #911

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Manual Scenario

Re-checked on scenario from #1003 -- now works correctly.

Checklist (remove irrelevant options):

This is the author self-check list

  • The change followed the style guidelines of the UTBot project
  • Self-review of the code is passed
  • The change contains enough commentaries, particularly in hard-to-understand areas
  • New documentation is provided or existed one is altered
  • No new warnings
  • New tests have been added
  • All tests pass locally with my changes

@volivan239 volivan239 marked this pull request as ready for review September 28, 2022 14:14
@volivan239 volivan239 enabled auto-merge (squash) September 28, 2022 14:36
@volivan239 volivan239 merged commit 560ac03 into main Sep 28, 2022
@volivan239 volivan239 deleted the volivan239/fix_kotlin_getters_setters_appear_in_ui branch September 28, 2022 16:31
AbdullinAM pushed a commit to AbdullinAM/UTBotJava that referenced this pull request Oct 17, 2022
AbdullinAM pushed a commit to AbdullinAM/UTBotJava that referenced this pull request Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autogenerated Kotlin getters/setters shouldn't be tested
2 participants