-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Binomial combinatorics #1926
Binomial combinatorics #1926
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise looks great! Thank you so much!
All good suggestions... and I've a long train journey tomorrow... |
…nna/agda-stdlib into binomial-combinatorics
Aaargh. More branch merge nonsense. Will revert. Blast! |
Yup it looks like the merge has gone wrong again. It seems to be a similar problem each time. What is the series of commands you're using to merge? |
Matthew, it seems to be a combination of things:
There are then second-order effects arising from (still!) not getting right how to revert such changes far enough back to undo the mess, and then re-committing the 'good' commits---I seem always to be off-by-one in one direction of time or the other. I'm snowed under with other things right now, so it will be next week now before I dig my way back out of this one. One copy I have is still (relatively) clean, so I may simply push commits from there to a fresh branch. Sorry that this will screw up the reviewing, but it seems more reliable than trying to fix up a broken tree on the remote branch. But I will also investigate that as well. I should by now have learnt that being prompted to record a merge commit message is sign of doing something wrong; if I I |
OK... @MatthewDaggitt can you review the latest round of commits to make sure that this is OK... there still seem to be some spurious commits associated with CHANGELOG1.7.2, but I haven't been able to track those down to eliminate them :-( It appears I have (once again: time to put me out to pasture, perhaps) reverted an irrelevant change, in this case Jacques' "minor whitespace violation" #1922 . Any way, when merging the present branch, to avoid these two? Sigh... UPDATED: OK, hopefully that last commit really should be the last... |
Thanks @MatthewDaggitt but I think you should have squashed those commits... they each seem to have contributed to my tally on the contributors page, which is the wrong arithmetic, i think. |
This is a stand-alone contribution, which proves the hard combinatorial part of the Binomial Theorem (cf #1287 ), viz.
together with some miscellaneous additional supporting lemmas.