This repository was archived by the owner on Mar 5, 2025. It is now read-only.
Do not calculate position on hidden elements #149
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an slider is hidden on init, it will always set its min attribute as its value. This overwrites any default value that is set via the value attribute.
This commit will prevent a hidden element from calculating its position and instead rely on the defaults set.
This will also prevent any the onSlide and onSlideEnd callbacks from being run on a hidden element - however if it's hidden, these wouldn't be trigger-able anyway!