This repository was archived by the owner on Mar 5, 2025. It is now read-only.
Doesn't work inside a display: none !important container #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rangeslider doesn't work if it is initialized inside a hidden container where display: none has been forced with an **!important** declaration. This way to hide elements is used by Bootstrap, HTML5 Boilerplate, ...
```css
.hidden {
display: none !important;
}
```
```html
<div class="hidden"">
<input type="range" />
</div>
```
This is because hiddenParentNodes[i].style.display = 'block' doesn't override important style. My fix correct this problem.
andreruffert
added a commit
that referenced
this pull request
Nov 29, 2015
Doesn't work inside a display: none !important container
|
@gwarnants thanks! 😊:v: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rangeslider doesn't work if it is initialized inside a hidden container where display: none has been forced with an !important declaration. This way to hide elements is used by Bootstrap, HTML5 Boilerplate, ...
This is because hiddenParentNodes[i].style.display = 'block' doesn't override class level important style. My fix correct this problem.