Keep Placeholder activated in multipleSelect component

[fabioel]

Hello!
I stumbled upon a problem today that is caused by the following lines:
uiSelectMultipleDirective.js

ctrl.getPlaceholder = function(){
        //Refactor single?
        if($select.selected && $select.selected.length) return;
        return $select.placeholder;
      };

I would like to have my placeholder activated even after I selected the first option in a multiple select component. Is there a plan to refactor this? Maybe to use a property like: keepPlaceholder

Thanks!

[user378230]

See discussion in #1433

Can you put together a PR with tests for it?

[DmitryGonchar]

@user378230 Which approach is better to fix this?

Should we move getPlaceholder() to uiSelectSingle and change $selectMultiple.getPlaceholder() to $select.getPlaceholder() in all three templates?

Or, another option is to add

if($select.getPlaceholder)
          return $select.getPlaceholder();

into existing function

[Jefiozie]

Hi @DmitryGonchar I think it is best to go for the first option. Are you going to make the PR?

Thanks.

[DmitryGonchar]

@Jefiozie I will have time only at the weekend. Are you sure option 1) will not break some other use cases? Or is it all covered with tests?

[moussa-b]

Hi, I would also need this feature for ui-select multiple, I have navigated through the three tickets concerning this feature (the current one, #1433 and #1612). And I am not sure, the feature is present for ui-select non-multiple and not present for ui-select multiple, that's it?

I am asking that because I have tried to get this work but didn't managed to. Here is a plunker : http://plnkr.co/edit/u5sNZ77dtaXMht3uTcnw?p=preview

[moussa-b]

Any update on that ticket please?

[DmitryGonchar]

@Jefiozie what about answers for #1796 (comment)?

Option 2 seems to be a safer one if you are not sure

[DmitryGonchar]

@fabioel and others
When this PR is merged - you can get the desired behavior (on demand) with something like this:

angular.module('myApp').directive('myAppUiSelectPlaceholderAlwaysVisible', function() {
  return {
    require: 'uiSelect',
    link: function($scope, $element, attrs, $select) {
      $select.getPlaceholder = function () {
        return $select.placeholder;
      }
    }
  }
});

And then add this directive as an attribute to the <ui-select my-app-ui-select-placeholder-always-visible> html element where this behavior is needed

Or you can override this function globally, of course

[moussa-b]

Hi @DmitryGonchar thanx for your fix I have tested it locally by copying/pasting your code, and it works well. Any idea when is scheduled the next release with your pull request? This ticket is nearly one year old

[DmitryGonchar]

No idea. When @Jefiozie merges it, I am not the maintainer.

[rhyskoedijk]

+1 on merging this please. @Jefiozie