This repository was archived by the owner on Oct 2, 2019. It is now read-only.
fix($selectMultiple): allow user to override getPlaceholder() Behavior
#2015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
NOTE: user cannot override |
User can provide their custom `getPlaceholder()` function. E.g. to keep placeholder activated in multipleSelect component, you can use this one:
```
angular.module('myApp').directive('myAppUiSelectPlaceholderAlwaysVisible', function() {
return {
require: 'uiSelect',
link: function($scope, $element, attrs, $select) {
$select.getPlaceholder = function () {
return $select.placeholder;
}
}
}
});
```
And then add this directive to the `<ui-select>` html element
closes angular-ui#1796
Jefiozie
reviewed
Jun 26, 2017
src/uiSelectController.js
Outdated
| @@ -65,6 +65,12 @@ uis.controller('uiSelectCtrl', | |||
| return isNil(ctrl.selected) || ctrl.selected === '' || (ctrl.multiple && ctrl.selected.length === 0); | |||
| }; | |||
|
|
|||
| ctrl.getPlaceholder = function(){ | |||
| //Refactor single? | |||
There was a problem hiding this comment.
Can you remove this comment?
Jefiozie
reviewed
Jun 26, 2017
test/select.spec.js
Outdated
| @@ -15,6 +15,14 @@ describe('ui-select tests', function () { | |||
| Escape: 27 | |||
| }; | |||
|
|
|||
| var multipleTagsTmpl = | |||
There was a problem hiding this comment.
Can't you use createUiSelectMultiple
Jefiozie
suggested changes
Jun 26, 2017
|
@Jefiozie done Btw, have you considered splitting tests into multiple files? Better readability, mainainability, it will be clear which tests relate to what and which helper functions available. Also will be easier to run only tests you are working on during dev phase. |
|
@Jefiozie How about merging this one? |
Jefiozie
approved these changes
Aug 3, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User can provide their custom
getPlaceholder()function. E.g. to keep placeholder activated in multipleSelect component, you can use this one:And then add this directive to the
<ui-select>html elementcloses #1796