Skip to content
This repository was archived by the owner on Oct 2, 2019. It is now read-only.

fix(uiSelectCtrl): fix input width calculations #2016

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

DmitryGonchar
Copy link
Contributor

input is not too big or too small - it takes the whole remaining part of the current row.
If smaller than the min input width - goes to the next row

closes #1980, possibly #2010

input is not too big or too small - it takes the whole remaining part of the current row.
If smaller than the min input width - goes to the next row

closes angular-ui#1980, possibly angular-ui#2010
@DmitryGonchar
Copy link
Contributor Author

DmitryGonchar commented Jun 17, 2017

@Jefiozie
It works locally when I run gulp test (and it opens Chrome), but does not work in Travis (in Firefox)
Looks like selected item width is different in Travis tests somehow.

Actually, these tests pass locally with Firefox (changed in karma.conf). So, this is NOT a browser issue. Something with Travis?

Do you know how to fix this test or Travis env?

@Jefiozie Jefiozie self-requested a review June 21, 2017 05:18
@Jefiozie
Copy link
Contributor

I think it has something to do with the Firefox version (31) but I don't know this for sure. Basically your test is saying it should be 792 px ( it think) and in the Firefox 31 browser this isn't the case. Do you see local problems when running it on IE or Edge?

@Jefiozie Jefiozie removed their request for review June 26, 2017 06:37
Add missing plugins for IE and Edge
@DmitryGonchar
Copy link
Contributor Author

DmitryGonchar commented Jun 27, 2017

@Jefiozie No problems, successful tests in both.

Btw, added a new commit for missing karma plugins to be able to run tests in these browsers

Tags with different names have different width, so unfortunately width can only be hardcoded (afaik). But it is the same in all browsers when run locally (tests run successfully).

I have karma-firefox-launcher v0.1.7 if that matters.

lameyer added a commit to looker/ui-select that referenced this pull request Jun 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Input box for ui-select multiple ALWAYS forcing text entry at new line
2 participants