This repository was archived by the owner on Oct 2, 2019. It is now read-only.
fix(uiSelectCtrl): properly calculate container width #2045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zollinger
force-pushed
the
fix/search-input-width
branch
from
cea08ca to
58ddba9
Compare
- Account for paddings on input container in case box-sizing: border-box is set. - Added some tests for this case Closes angular-ui#1980.
zollinger
force-pushed
the
fix/search-input-width
branch
from
58ddba9 to
c66a262
Compare
|
I find that the bug persists even without padding because the |
|
I'm running this fix on a production app without problems. Could you maybe create a jsfiddle showing the issue? |
|
After some more digging, I've found that the cause is if there is no left or right padding on the element. http://plnkr.co/edit/EKXqPepAaswBpOAr9W34?p=preview |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
is set.
The other open PR (
#2016) regarding this issue does not work without jQuery.
Closes #1980.